Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proxy: send explicit charset=utf-8 #4793

Merged
merged 1 commit into from
May 30, 2022
Merged

Proxy: send explicit charset=utf-8 #4793

merged 1 commit into from
May 30, 2022

Conversation

mmeeks
Copy link
Contributor

@mmeeks mmeeks commented May 19, 2022

https: //github.com/nextcloud/richdocuments/issues/2196
Signed-off-by: Michael Meeks michael.meeks@collabora.com
Change-Id: I4fce74290e8bf8a6681922a2165772933443703e

  • Resolves: #
  • Target version: master

Summary

TODO

  • ...

Checklist

  • Code is properly formatted
  • All commits have Change-Id
  • I have run tests with make check
  • I have issued make run and manually verified that everything looks okay
  • Documentation (manuals or wiki) has been updated or is not required

@mmeeks
Proxy: send explicit charset=utf-8
6ecdb82 
https: //github.com/nextcloud/richdocuments/issues/2196
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: I4fce74290e8bf8a6681922a2165772933443703e
@mmeeks mmeeks mentioned this pull request May 19, 2022
Closed
@mmeeks mmeeks requested a review from thebearon May 19, 2022 18:57
@mmeeks mmeeks requested a review from timar May 30, 2022 09:14
@mmeeks
Copy link
Contributor Author

mmeeks commented May 30, 2022

@timar can you have a look ?

timar
timar approved these changes May 30, 2022
View reviewed changes
Copy link
Member

@timar timar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can merge this, because it won't make things worse. Testing of richdocumentscode that has this patch will show if the fix was good. It would be difficult and time consuming to test the patch in a development environment.

@timar timar merged commit 7eb3575 into master May 30, 2022
@timar timar deleted the private/mmeeks/fixproxy branch May 30, 2022 09:32
@netadm001
Copy link

Hi, thanks for your time about this little bug I found.
When the update arrive on NC apps, I make ASAP a feedback to you :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timar timar timar approved these changes

@thebearon thebearon Awaiting requested review from thebearon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmeeks @netadm001 @timar