-
Notifications
You must be signed in to change notification settings - Fork 681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added image path for icons when toggle to dark theme #6356
Added image path for icons when toggle to dark theme #6356
Conversation
fa76619
to
1f3b6df
Compare
looks good :) can we do one more improvement:
then we have to use one function instead 2 :) |
4b02cf1
to
b1ae392
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works as expected :)
11e005b
to
413e4d5
Compare
e174ea4
to
99ab0ca
Compare
3c60c19
to
69470e5
Compare
9655771
to
d93156a
Compare
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com> Change-Id: I14a99df7cf10bf73f898f15d3aaa5a32c9cd51af
d93156a
to
ff43b94
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, @pedropintosilva if you are ok we can merge
Thanks, pulling now to test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Change-Id: I14a99df7cf10bf73f898f15d3aaa5a32c9cd51af
Current case when we toggle to dark mode icons are not getting change because we are using default image path when we call get image url.
so i changed it according to the theme we are using and if icon does not present in dark theme then use the default icon.
@pedropintosilva , @eszkadev => need your review for this changes i made