we don't need to round-trip through core to reposition notes #7546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caolanm
force-pushed
the
private/caolanm/drop_unneeded_comment_refetches
branch
from
4e37223
to
0a66d7c
Compare
we know where they are by cell addresses, so defer getting the screen positions until we need them and we don't need to get core to trigger recalculating them. When we redraw the comments after the new geometry arrives then we can place them via the address. When adding a new note we want to know the range of the potentially merged cells we are inserting into. #7334 https://gerrit.libreoffice.org/c/core/+/158560 needs to be applied to solve the problem described there that becomes apparent when this is in place. Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com> Change-Id: I3228dc8fa8d47ba4e796e50427c125d7f78fe5fc
caolanm
force-pushed
the
private/caolanm/drop_unneeded_comment_refetches
branch
from
0a66d7c
to
6f38417
Compare
mmeeks
approved these changes
Oct 30, 2023
|
grouping/ungrouping looks ok, inserting rows and cols not so much. So https://gerrit.libreoffice.org/c/core/+/158718 to tell the client when a note has moved to another cell |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we know where they are by cell addresses, so defer getting the screen positions until we need them and we don't need to get core to trigger recalculating them. When we redraw the comments after the new geometry arrives then we can place them via the address.
When adding a new note we want to know the range of the potentially merged cells we are inserting into.
#7334
https://gerrit.libreoffice.org/c/core/+/158560 needs to be applied to solve the problem described there that becomes apparent when this is in place.
Change-Id: I3228dc8fa8d47ba4e796e50427c125d7f78fe5fc
Summary
TODO
Checklist
make checkmake runand manually verified that everything looks okay