Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

we don't need to round-trip through core to reposition notes #7546

Merged
merged 1 commit into from
Nov 2, 2023

Commits on Oct 29, 2023

  1. we don't need to round-trip through core to reposition notes

    we know where they are by cell addresses, so defer getting
    the screen positions until we need them and we don't need
    to get core to trigger recalculating them. When we redraw
    the comments after the new geometry arrives then we can place
    them via the address.
    
    When adding a new note we want to know the range of the
    potentially merged cells we are inserting into.
    
    #7334
    
    https://gerrit.libreoffice.org/c/core/+/158560 needs to be
    applied to solve the problem described there that becomes
    apparent when this is in place.
    
    Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
    Change-Id: I3228dc8fa8d47ba4e796e50427c125d7f78fe5fc
    caolanm committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    6f38417 View commit details
    Browse the repository at this point in the history