loleaflet: fix "offsetWidth" property value of the sidebar panel #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately when show/hide sidebar the "offsetWidth" property works only if the element is visible otherwise it returns parent empty size. To fix add temporary a visibility property, then obtain the sidebar "offsetWidth" property and update document container size. Change-Id: I8e1c821518a4c155340edcfc8f2313098edff8b0 Signed-off-by: Henry Castro <hcastro@collabora.com>
hcvcastro
force-pushed
the
pr-sidebar-00
branch
from
cb981a1
to
3a5b04f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately when show/hide sidebar the "offsetWidth" property
works only if the element is visible otherwise it returns parent
empty size.
To fix add temporary a visibility property, then obtain the sidebar
"offsetWidth" property and update document container size.
Change-Id: I8e1c821518a4c155340edcfc8f2313098edff8b0
Signed-off-by: Henry Castro hcastro@collabora.com