[FIX]:- Optimization/hr module codebase #3394
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…timization/hr-module-codebase
|
Coverage report for commit: eea1ecd Summary - Lines: 3.00% | Methods: 5.22%
🤖 comment via lucassabreu/comment-coverage-clover |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3394 +/- ##
========================================
Coverage 3.38% 3.38%
Complexity 584 584
========================================
Files 103 103
Lines 2065 2065
========================================
Hits 70 70
Misses 1995 1995 ☔ View full report in Codecov by Sentry. |
Passing run #7886 ↗︎
Details:
Review all test suite changes for PR #3394 ↗︎ |
|||||||||||||||
Ayush8923
added
the
status : ready for review
Ayush8923
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ApplicationControllerand theApplicationServicefrom which the Recruitment data is rendered, there was a little bit of the same code in both these files, but we used only theApplicationControllerto fetch the data. In this, Code duplication was happening on this. We have moved all the changes in theApplicationControllerto theApplicationServicefile which will be totally used to fetch the data.