refactor!: wrap dynamics in Expr classes #115
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by ComPWA/compwa.github.io#37 and ComPWA/compwa.github.io#43, which required to re-define coupled width and other dynamics in terms of a class to make them render nicely, all expression nodes of dynamics functions are formulated in terms of
sympy.Expr
classes. This has been made possible with #114.Note some major interface changes:
coupled_width
->CoupledWidth
breakup_momentum_squared
->BreakupMomentumSquared
phase_space_factor
->PhaseSpaceFactor
(for this, the
PhaseSpaceFactor
had to be renamed toPhaseSpaceFactorProtocol
)The
breakup_momentum
function has been removed.