refactor!: normalize function in NLL #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redeboer
reviewed
Jan 7, 2021
spflueger
force-pushed
the
normalization
branch
from
12fc409
to
35ee6d4
Compare
Codecov Report
@@ Coverage Diff @@
## master #192 +/- ##
==========================================
- Coverage 82.17% 81.71% -0.47%
==========================================
Files 13 13
Lines 707 722 +15
Branches 98 99 +1
==========================================
+ Hits 581 590 +9
- Misses 91 99 +8
+ Partials 35 33 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
redeboer
force-pushed
the
normalization
branch
from
35ee6d4
to
d15d50d
Compare
spflueger
force-pushed
the
normalization
branch
from
f4f6ddd
to
cdd023b
Compare
Cast value returned by clebsch gordan function of sympy evalf to float and make compatible with tensorflow again.
The NLL estimator should now get an unnormalized function and performs the normalization with the required phase space sample.
spflueger
force-pushed
the
normalization
branch
from
2ba9c0e
to
019bf9d
Compare
spflueger
force-pushed
the
normalization
branch
from
8f02a26
to
8831d3b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The expertsystem was changed to not normalize the Intensity automatically anymore. To adapt to this change, the NLL estimator now gets another required argument, a phase space dataset. This is used to normalize the function.
Closes #191