Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: check shape of kinematics dataset #194

Merged
merged 5 commits into from
Jan 7, 2021
Merged

test: check shape of kinematics dataset #194

merged 5 commits into from
Jan 7, 2021

Conversation

redeboer
Copy link
Member

@redeboer redeboer commented Jan 7, 2021

The doc CI for #192 fails because the shape of the data set that is returned by HelicityKinematics.convert is incorrect: its values contain floats, and should all be lists. This PR adds a test that checks the shape.

@redeboer redeboer self-assigned this Jan 7, 2021
@redeboer
Copy link
Member Author

redeboer commented Jan 7, 2021

@spflueger The test will fail here too. Strange though that a dataset has the correct format in the example notebook, but that the one in the tests contains float values (not wrapped in a list).

@redeboer redeboer added 🐛 Bug Something isn't working 🔨 Maintenance Maintenance and upkeep improvements labels Jan 7, 2021
@redeboer
Copy link
Member Author

redeboer commented Jan 7, 2021

Note: I assume the shape of a data set (a dict of ndarrays) to be such that it can be directly converted into a pandas.DataFrame, like happens here:
https://pwa.readthedocs.io/projects/tensorwaves/en/0.1.3/usage/2_generate_data.html#visualize-kinematic-variables

@redeboer redeboer removed the request for review from spflueger January 7, 2021 20:11
@redeboer redeboer added 🖱️ DX Improvements to the Developer Experience and removed 🐛 Bug Something isn't working 🔨 Maintenance Maintenance and upkeep improvements labels Jan 7, 2021
@codecov
Copy link

codecov bot commented Jan 7, 2021

Codecov Report

Merging #194 (eec0bfa) into master (6eebdf5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #194   +/-   ##
=======================================
  Coverage   82.17%   82.17%           
=======================================
  Files          13       13           
  Lines         707      707           
  Branches       98       98           
=======================================
  Hits          581      581           
  Misses         91       91           
  Partials       35       35           
Flag Coverage Δ
unittests 82.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@redeboer redeboer merged commit d5e2b5a into master Jan 7, 2021
@redeboer redeboer deleted the test-kinematics branch January 7, 2021 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🖱️ DX Improvements to the Developer Experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant