-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add scipy Optimizer adapter #231
Conversation
Also move parameter flattening code into separate private submodule.
Codecov Report
@@ Coverage Diff @@
## master #231 +/- ##
==========================================
+ Coverage 81.23% 81.65% +0.42%
==========================================
Files 10 12 +2
Lines 453 507 +54
Branches 61 64 +3
==========================================
+ Hits 368 414 +46
- Misses 64 71 +7
- Partials 21 22 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Hey, that looks nice, but I think we should have a chat again in order to avoid duplication (as we're adding an improved interface in zfit right now |
Hey Jonas, thanks for the comment. Sure, how about next week? We still have to prepare some things for friday. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GJ! Some inline comments, but I approve.
There are similarities between the minuit
and scipy
submodules now, we can think about how to clean that up in a follow-up PR.
No description provided.