Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid cell magic in colab cell #251

Merged
merged 1 commit into from
Mar 26, 2021
Merged

fix: avoid cell magic in colab cell #251

merged 1 commit into from
Mar 26, 2021

Conversation

redeboer
Copy link
Member

Follow-up to #250. The cell magic conditionals didn't work well, which slowed down CI.

@redeboer redeboer added the 🐛 Bug Something isn't working label Mar 26, 2021
@redeboer redeboer added this to the Release 0.2.2 milestone Mar 26, 2021
@redeboer redeboer self-assigned this Mar 26, 2021
@redeboer
Copy link
Member Author

There's still another bug related to the custom hook (which create this colab cell): they do not work in the tox -e sty job. So eventually I want to move these hooks out again from the repo and put them under a separate ComPWA/pre-commit-hooks repository (which allows you to install the hook as a repo hook with python as language).
https://pre-commit.com/#new-hooks

@codecov
Copy link

codecov bot commented Mar 26, 2021

Codecov Report

Merging #251 (e91bb8d) into master (1e36bfc) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #251   +/-   ##
=======================================
  Coverage   77.70%   77.70%           
=======================================
  Files          13       13           
  Lines         619      619           
  Branches       92       92           
=======================================
  Hits          481      481           
  Misses        103      103           
  Partials       35       35           
Flag Coverage Δ
unittests 77.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@redeboer redeboer merged commit d960746 into master Mar 26, 2021
@redeboer redeboer deleted the fix-colab-cell branch March 26, 2021 16:32
@redeboer redeboer modified the milestones: 0.2.4, 0.2.2 May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant