Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve output of YAMLSummary #252

Merged
merged 2 commits into from
Mar 26, 2021
Merged

fix: improve output of YAMLSummary #252

merged 2 commits into from
Mar 26, 2021

Conversation

redeboer
Copy link
Member

Two fixes for the YAMLSummary:

  • Scalar tensors are converted to built-in complex or float, so that they are rendered more nicely in the output of YAMLSummary.
  • YAMLSummary now also dumps in on_optimize_end(), so that the load_latest_parameters indeed returns the latest parameters (see test_callbacks.py).

(Rebased on #251)

@redeboer redeboer added the 🐛 Bug Something isn't working label Mar 26, 2021
@redeboer redeboer added this to the Release 0.2.2 milestone Mar 26, 2021
@redeboer redeboer self-assigned this Mar 26, 2021
@redeboer redeboer changed the title Fix yaml summary fix: improve output of YAMLSummary Mar 26, 2021
@codecov
Copy link

codecov bot commented Mar 26, 2021

Codecov Report

Merging #252 (64e790a) into master (d960746) will decrease coverage by 0.45%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #252      +/-   ##
==========================================
- Coverage   77.70%   77.25%   -0.46%     
==========================================
  Files          13       13              
  Lines         619      633      +14     
  Branches       92       96       +4     
==========================================
+ Hits          481      489       +8     
- Misses        103      106       +3     
- Partials       35       38       +3     
Flag Coverage Δ
unittests 77.25% <60.00%> (-0.46%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/tensorwaves/optimizer/callbacks.py 63.79% <60.00%> (-0.59%) ⬇️

@redeboer redeboer merged commit 97e729f into master Mar 26, 2021
@redeboer redeboer deleted the fix-YAMLSummary branch March 26, 2021 16:48
@redeboer redeboer modified the milestones: 0.2.4, 0.2.2 May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant