-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement FitResult.count_number_of_parameters #291
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
@Leongrim, hope you agree with #290 (comment), that this PR serves as a sufficient solution to #290. For AIC and BIC, see changes to step 3. |
f87b0ed
to
2c60e8f
Compare
Codecov Report
@@ Coverage Diff @@
## main #291 +/- ##
==========================================
- Coverage 81.25% 80.54% -0.71%
==========================================
Files 13 13
Lines 816 843 +27
==========================================
+ Hits 663 679 +16
- Misses 153 164 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Closes #290
FitResult.count_number_of_parameters()
FitResult
are now validated. This is to ensure that functions and methods likecount_number_of_parameters()
keep working.FitResult
are now 'pretty printed' below each other, e.g.:ParameterValue
where possible instead ofUnion[...]
.