Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename real argument to complex_twice #297

Merged
merged 1 commit into from
Jun 24, 2021
Merged

Conversation

redeboer
Copy link
Member

Fix-up to #291, e.g.:

FitResult.count_number_of_parameter(complex_twice=True)

See discussion here
https://app.reviewnb.com/ComPWA/tensorwaves/blob/main/docs/usage/step3.ipynb/#comment-19307800

@redeboer redeboer added the ⚠️ Interface Breaking changes to the API label Jun 24, 2021
@redeboer redeboer added this to the 0.3.0 milestone Jun 24, 2021
@redeboer redeboer requested a review from Leongrim June 24, 2021 11:54
@redeboer redeboer self-assigned this Jun 24, 2021
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@redeboer redeboer enabled auto-merge (squash) June 24, 2021 11:55
@codecov
Copy link

codecov bot commented Jun 24, 2021

Codecov Report

Merging #297 (5062a4e) into main (c989402) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #297   +/-   ##
=======================================
  Coverage   80.52%   80.52%           
=======================================
  Files          13       13           
  Lines         837      837           
=======================================
  Hits          674      674           
  Misses        163      163           
Flag Coverage Δ
unittests 80.52% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/tensorwaves/interface.py 75.92% <100.00%> (ø)

@redeboer redeboer disabled auto-merge June 24, 2021 12:07
@redeboer redeboer merged commit f4c8ec6 into main Jun 24, 2021
@redeboer redeboer deleted the complex_twice branch June 24, 2021 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚠️ Interface Breaking changes to the API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant