1258 avoid setting key when creating attachment #1259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LCOV of commit
|
PiTrem
force-pushed
the
1258-avoid-setting-key-when-creating-attachment
branch
from
db509e7
to
4f24f69
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
app/api/helpers/container_helpers.rb
Outdated
| @@ -79,7 +79,7 @@ def create_or_update_attachments(container, attachments) | |||
| return unless can_update | |||
| attachments.each do |att| | |||
| if att[:is_new] | |||
| attachment = Attachment.where(storage: 'tmp', key: att[:id]).last | |||
| attachment = Attachment.where(key: att[:id]).last | |||
There was a problem hiding this comment.
Metrics/CyclomaticComplexity: Cyclomatic complexity for create_or_update_attachments is too high. [10/7]
app/api/helpers/container_helpers.rb
Outdated
| @@ -79,7 +79,7 @@ def create_or_update_attachments(container, attachments) | |||
| return unless can_update | |||
| attachments.each do |att| | |||
| if att[:is_new] | |||
| attachment = Attachment.where(storage: 'tmp', key: att[:id]).last | |||
| attachment = Attachment.where(key: att[:id]).last | |||
There was a problem hiding this comment.
Metrics/PerceivedComplexity: Perceived complexity for create_or_update_attachments is too high. [11/8]
PiTrem
force-pushed
the
1258-avoid-setting-key-when-creating-attachment
branch
from
009b3a2
to
1f0b021
Compare
do not set a fix key while creating attachments as it otherwise produces the same file path for all template attachments
(kept the TransferFileFromTmpJob for now: need to ensure there is no instance of it being queued)
PiTrem
force-pushed
the
1258-avoid-setting-key-when-creating-attachment
branch
from
1f0b021
to
0e30667
Compare
| @@ -825,7 +825,7 @@ | |||
| describe 'update sample analysis with a new dataset and a new img file' do | |||
| before do | |||
| attachment = Attachment.find_by(filename: 'upload.jpg') | |||
| attachment.key = '8580a8d0-4b83-11e7-afc4-85a98b9d0194' | |||
| attachment.attachable = nil | |||
There was a problem hiding this comment.
RSpec/MultipleMemoizedHelpers: Example group has too many memoized helpers [19/10]
| @@ -825,7 +825,7 @@ | |||
| describe 'update sample analysis with a new dataset and a new img file' do | |||
| before do | |||
| attachment = Attachment.find_by(filename: 'upload.jpg') | |||
| attachment.key = '8580a8d0-4b83-11e7-afc4-85a98b9d0194' | |||
| attachment.attachable = nil | |||
There was a problem hiding this comment.
Layout/TrailingWhitespace: Trailing whitespace detected.
LCOV of commit
|
FabianMauz
approved these changes
Apr 11, 2023
PiTrem
added a commit
that referenced
this pull request
Apr 11, 2023
* use db-generated identifier to build the shrine id * fix seed for report templates: do not set a fix key while creating attachments as it otherwise produces the same file path for all template attachments * Attachment: clean deprecated logic updating the storage attribute (kept the TransferFileFromTmpJob for now: need to ensure there is no instance of it being queued) * do not set attachment storage to tmp (default 'local') * upd specs
mekkyz
pushed a commit
that referenced
this pull request
Sep 21, 2023
* use db-generated identifier to build the shrine id * fix seed for report templates: do not set a fix key while creating attachments as it otherwise produces the same file path for all template attachments * Attachment: clean deprecated logic updating the storage attribute (kept the TransferFileFromTmpJob for now: need to ensure there is no instance of it being queued) * do not set attachment storage to tmp (default 'local') * upd specs
baolanlequang
pushed a commit
that referenced
this pull request
Mar 5, 2024
* use db-generated identifier to build the shrine id * fix seed for report templates: do not set a fix key while creating attachments as it otherwise produces the same file path for all template attachments * Attachment: clean deprecated logic updating the storage attribute (kept the TransferFileFromTmpJob for now: need to ensure there is no instance of it being queued) * do not set attachment storage to tmp (default 'local') * upd specs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.