1260 report UI to not break if a report template cannot be found #1261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pending a rework on the report template.
fix wrong assignment that save report the template id.
fall back to standard template
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -219,6 +218,7 @@ def is_int? | |||
| requires :imgFormat, type: String, default: 'png', values: %w[png eps emf] | |||
| requires :fileName, type: String, default: 'ELN_Report_' + Time.now.strftime('%Y-%m-%dT%H-%M-%S') | |||
| requires :templateId, type: String | |||
| optional :templateType, type: String, default: 'standard', values: ReportTemplate::REPORT_TYPES | |||
There was a problem hiding this comment.
Metrics/ClassLength: Class has too many lines. [240/200]
| else | ||
| report_template.report_type | ||
| end | ||
| # tpl_path = if report_template.attachment |
There was a problem hiding this comment.
Metrics/AbcSize: Assignment Branch Condition size for create_docx is too high. [<4, 25, 8> 26.55/25]
| else | ||
| report_template.report_type | ||
| end | ||
| # tpl_path = if report_template.attachment |
There was a problem hiding this comment.
Metrics/CyclomaticComplexity: Cyclomatic complexity for create_docx is too high. [8/7]
| else | ||
| report_template.report_type | ||
| end | ||
| # tpl_path = if report_template.attachment |
There was a problem hiding this comment.
Metrics/MethodLength: Method has too many lines. [37/30]
| # report_template.attachment.attachment_url | ||
| # else | ||
| # report_template.report_type | ||
| # end |
There was a problem hiding this comment.
Layout/CommentIndentation: Incorrect indentation detected (column 0 instead of 6).
| # else | ||
| # report_template.report_type | ||
| # end | ||
| tpl_path = self.class.template_path(template) |
There was a problem hiding this comment.
Style/IdenticalConditionalBranches: Move tpl_path = self.class.template_path(template) out of the conditional.
LCOV of commit
|
LCOV of commit
|
PiTrem
added a commit
that referenced
this pull request
Apr 11, 2023
* define report types * Report to use default template file pending a rework on the report template. * disable Admin Report Template Managment * devmode: report job to perform now * Report: save template type in reports.template in report fix wrong assignment that save report the template id. * Report: alert if template not found when reloading an archive settings fall back to standard template * add more tests for creating reports --------- Co-authored-by: FabianMauz <fmauz@ipb-halle.de>
PiTrem
deleted the
1260-report-ui-to-not-break-if-a-report-template-cannot-be-found
branch
mekkyz
pushed a commit
that referenced
this pull request
Sep 21, 2023
* define report types * Report to use default template file pending a rework on the report template. * disable Admin Report Template Managment * devmode: report job to perform now * Report: save template type in reports.template in report fix wrong assignment that save report the template id. * Report: alert if template not found when reloading an archive settings fall back to standard template * add more tests for creating reports --------- Co-authored-by: FabianMauz <fmauz@ipb-halle.de>
baolanlequang
pushed a commit
that referenced
this pull request
Mar 5, 2024
* define report types * Report to use default template file pending a rework on the report template. * disable Admin Report Template Managment * devmode: report job to perform now * Report: save template type in reports.template in report fix wrong assignment that save report the template id. * Report: alert if template not found when reloading an archive settings fall back to standard template * add more tests for creating reports --------- Co-authored-by: FabianMauz <fmauz@ipb-halle.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
disabled Admin Report Template management and set paths for report type (do not use the report_template.attachment (also due to 1258 avoid setting key when creating attachment #1259 ))
save report type in report (fix wrong assignment)
fall back to standard report if the report-template does not exist anymore in the db