fixup(dev): device seed #1945
Merged
fixup(dev): device seed #1945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PiTrem
force-pushed
the
1941-bundle-exec-rails-dbsetup-fails-in-development
branch
2 times, most recently
from
076c837
to
e01bbe2
Compare
LCOV of commit
|
JanCBrammer
reviewed
May 27, 2024
db/seeds/development/devices.seed.rb
Outdated
There was a problem hiding this comment.
bundle exec rails db:setup fails with
*** Loading development seed data from /home/chemotion-dev/app/db/seeds/development/devices.seed.rb
Creating device D1...
rails aborted!
ActiveRecord::RecordInvalid: Validation failed: Datacollector dir Watch directory is not a valid directory
/home/chemotion-dev/app/db/seeds/development/devices.seed.rb:38:in `block in <main>'
/home/chemotion-dev/app/db/seeds/development/devices.seed.rb:36:in `each'
/home/chemotion-dev/app/db/seeds/development/devices.seed.rb:36:in `<main>'
/home/chemotion-dev/app/db/seeds.rb:15:in `block (2 levels) in <main>'
/home/chemotion-dev/app/db/seeds.rb:13:in `each'
/home/chemotion-dev/app/db/seeds.rb:13:in `block in <main>'
/home/chemotion-dev/app/db/seeds.rb:4:in `each'
/home/chemotion-dev/app/db/seeds.rb:4:in `<main>'
Tasks: TOP => db:setup => db:seed
(See full trace by running task with --trace)
There was a problem hiding this comment.
2 options
- skip or trick the validation (update_columns or temporary set a datacollector config)
- have a compliant datacollector config
Went for the 2nd (although if a datacollector.yml is already there it should be checked)
LCOV of commit
|
PiTrem
force-pushed
the
1941-bundle-exec-rails-dbsetup-fails-in-development
branch
3 times, most recently
from
8e54a1f
to
43ff71d
Compare
use temporary datacollector config to pass validations
PiTrem
force-pushed
the
1941-bundle-exec-rails-dbsetup-fails-in-development
branch
from
43ff71d
to
03ce132
Compare
LCOV of commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NB: when updating the devices, validation might fail if the application datacollectors local path config
does not fit the one set for the device