Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate issues on Node 18.7+ #5

Closed
Comandeer opened this issue Jul 27, 2022 · 3 comments
Closed

Investigate issues on Node 18.7+ #5

Comandeer opened this issue Jul 27, 2022 · 3 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@Comandeer
Copy link
Owner

See https://github.com/Comandeer/esm-loader-manager/runs/7542860761?check_suite_focus=true

@Comandeer Comandeer added the bug Something isn't working label Jul 27, 2022
@Comandeer Comandeer added this to the v0.2.0 milestone Jul 27, 2022
@Comandeer Comandeer self-assigned this Jul 27, 2022
@Comandeer
Copy link
Owner Author

Error:

Error [ERR_LOADER_CHAIN_INCOMPLETE]: "file:///home/comandeer/repos/tools/esm-loader-manager/src/index.js 'load'" did not call the next hook in its chain and did not explicitly signal a short circuit. If this is intentional, include `shortCircuit: true` in the hook's return.
    at new NodeError (node:internal/errors:387:5)
    at ESMLoader.load (node:internal/modules/esm/loader:624:13)
    at async ESMLoader.moduleProvider (node:internal/modules/esm/loader:472:11) {
  code: 'ERR_LOADER_CHAIN_INCOMPLETE'
}

It seems to be connected with loader chaining introduced in Node 18.6.0.

@Comandeer
Copy link
Owner Author

Adding shortCircuit: true option to the loader should do the trick.

@Comandeer
Copy link
Owner Author

Fixed in 91aa46d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant