Skip to content
This repository has been archived by the owner on Mar 15, 2020. It is now read-only.

Preserve new line after banner comment #16

Closed
Comandeer opened this issue Apr 22, 2017 · 1 comment
Closed

Preserve new line after banner comment #16

Comandeer opened this issue Apr 22, 2017 · 1 comment
Assignees
@Comandeer
Labels
enhancement

Comments

@Comandeer
Copy link
Owner

Comandeer commented Apr 22, 2017 •
edited

Due to fact that plugins are run before presets, new line inserted by @comandeer/babel-plugin-banner is removed by babili. Let's find some solution to hack this!
@Comandeer Comandeer added this to the v3.0.0 milestone Apr 22, 2017
@Comandeer Comandeer self-assigned this Apr 22, 2017
@Comandeer Comandeer modified the milestones: v3.0.0, v3.1.0 Apr 22, 2017
@Comandeer
Copy link
Owner Author

Maybe consider https://github.com/Rich-Harris/magic-string?

@Comandeer Comandeer modified the milestones: 3.2.0, v3.1.0 Jun 10, 2017
Comandeer added a commit that referenced this issue Jan 26, 2018
@Comandeer
feat(banner): add new line support
8e7c998 
Add ability to add new line after banner using new configuration option, bannerNewLine.

closes #16
@Comandeer Comandeer mentioned this issue Jan 26, 2018
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Comandeer Comandeer

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Comandeer