Implicit Dns for IO only
#475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armanbilge
commented
Mar 22, 2023
| ThisBuild / tlBaseVersion := "3.2" | ||
| ThisBuild / tlBaseVersion := "3.3" |
There was a problem hiding this comment.
Source-breaking. FS2 will be affected, at least.
Comment on lines
-81
to
+80
| "org.typelevel" %%% "cats-effect-kernel" % "3.4.8", | ||
| "org.typelevel" %%% "cats-effect" % "3.4.8", |
There was a problem hiding this comment.
Now depend on Cats Effect core :)
Comment on lines
-25
to
+28
| implicit def forSync[F[_]](implicit F: Sync[F]): Dns[F] = new UnsealedDns[F] { | ||
| def forAsync[F[_]: Async]: Dns[F] = forSync // alias for cross-compiling w/ JS | ||
|
|
||
| def forSync[F[_]](implicit F: Sync[F]): Dns[F] = new UnsealedDns[F] { |
There was a problem hiding this comment.
I wonder if we should just make these def impl or something.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discord thread: https://discord.com/channels/632277896739946517/839257183782436945/1087761519477014644
tl;dr: The motivation for removing the implicit implementation for generic
F[_]is to force tagless final libs to declare all of their constraints (e.g.Dns) instead of deriving them on-the-spot from e.g.Async. Meanwhile, this change will be completely transparent to code written in concreteIO.Will follow-up with similar changes in FS2 for
Files,Network, etc.