Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reworking API for 1.0 and Java port #177

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

HaloFour
Copy link
Collaborator

No description provided.

@codecov-io
Copy link

codecov-io commented Feb 19, 2021

Codecov Report

Merging #177 (9e4cbc1) into master (15d23cd) will increase coverage by 0.04%.
The diff coverage is 89.74%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #177      +/-   ##
==========================================
+ Coverage   93.90%   93.94%   +0.04%     
==========================================
  Files          93       92       -1     
  Lines        1247     1190      -57     
  Branches       83       82       -1     
==========================================
- Hits         1171     1118      -53     
+ Misses         76       72       -4     
Impacted Files Coverage Δ
...src/main/scala/com/comcast/money/core/Tracer.scala 100.00% <ø> (ø)
.../scala/com/comcast/money/core/UnrecordedSpan.scala 12.50% <0.00%> (-1.79%) ⬇️
...la/com/comcast/money/otel/handlers/MoneyLink.scala 100.00% <ø> (ø)
...st/money/otel/handlers/MoneyReadableSpanData.scala 96.42% <ø> (ø)
.../scala/com/comcast/money/wire/SpanConverters.scala 86.95% <50.00%> (-1.81%) ⬇️
...c/main/scala/com/comcast/money/core/CoreSpan.scala 97.36% <100.00%> (+1.71%) ⬆️
...scala/com/comcast/money/core/CoreSpanBuilder.scala 100.00% <100.00%> (+5.88%) ⬆️
...scala/com/comcast/money/core/CoreSpanFactory.scala 100.00% <100.00%> (ø)
...a/com/comcast/money/core/MoneyTracerProvider.scala 83.33% <100.00%> (-4.17%) ⬇️
...la/com/comcast/money/core/internal/SpanLocal.scala 100.00% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15d23cd...9e4cbc1. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants