Merge pull request #823 from peuter/fix-diagram-pan-loading

use a debounced function to load diagram data after pan event
CometVisu · Jan 16, 2019 · aac4160 · aac4160
2 parents 76caa21 + 9a549fc
commit aac4160
Showing 1 changed file with 12 additions and 5 deletions.
diff --git a/source/class/cv/plugins/diagram/AbstractDiagram.js b/source/class/cv/plugins/diagram/AbstractDiagram.js
@@ -61,6 +61,16 @@ qx.Class.define('cv.plugins.diagram.AbstractDiagram', {
   include: [cv.ui.common.Operate, cv.ui.common.Refresh],
   type: "abstract",
 
+  /*
+  ***********************************************
+    CONSTRUCTOR
+  ***********************************************
+  */
+  construct: function (props) {
+    this.base(arguments, props);
+    this._debouncedLoadDiagramData = qx.util.Function.debounce(this.loadDiagramData.bind(this), 200);
+  },
+
   /*
   ******************************************************
     STATICS
@@ -600,11 +610,8 @@ qx.Class.define('cv.plugins.diagram.AbstractDiagram', {
       this.plotted = true;
 
       var that = this;
-      diagram.bind("plotpan", function(event, plot, args) {
-        // TODO and FIXME: args.dragEnded doesn't exist, so data isn't reloaded after pan end!
-        if (args.dragEnded) {
-          that.loadDiagramData( plot, isPopup, false );
-        }
+      diagram.bind("plotpan", function(event, plot) {
+        that._debouncedLoadDiagramData( plot, isPopup, false );
       }).bind("plotzoom", function() {
         that.loadDiagramData( plot, isPopup, false );
       }).bind("touchended", function() {