Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use a debounced function to load diagram data after pan event #823

Merged
merged 1 commit into from Jan 16, 2019

Conversation

peuter
Copy link
Member

@peuter peuter commented Jan 16, 2019

The debounce ensures that the backend is not "flooded" with requests during panning. The request is only send once after the last pan-event is at least 200ms ago, which has the nice side effect that the data is also loaded, when the user just stops dragging for at least 200ms, without releasing the mouse-button.

Fixes error reported here: https://knx-user-forum.de/forum/supportforen/cometvisu/1307234-test-cv11-dev?p=1314117#post1314117

@peuter peuter added this to the 0.11.0 milestone Jan 16, 2019
@peuter peuter added this to To do in Next Release via automation Jan 16, 2019
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 58.243% when pulling 9a549fc on peuter:fix-diagram-pan-loading into 6dac9ae on CometVisu:develop.

@ChristianMayer ChristianMayer merged commit aac4160 into CometVisu:develop Jan 16, 2019
Next Release automation moved this from To do to Done Jan 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Next Release
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants