Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle 404 config-error state better: #1227

Merged
merged 4 commits into from
Feb 27, 2022
Merged

Handle 404 config-error state better: #1227

merged 4 commits into from
Feb 27, 2022

Conversation

peuter
Copy link
Member

@peuter peuter commented Feb 26, 2022

  • Always be able to load the manager
  • If manager is loaded directly, do not load the config
  • If directly loaded manager is closes, open the config
  • allow config error to be closed, because you can do something in the manager then
  • fix history when manager is closed

@peuter
Handle 404 config-error state better:
635907b 
* Always be able to load the manager
* If manager is loaded directly, do not load the config
* If directly loaded manager is closes, open the config
* allow config error to be closed, because you can do something in the manager then
* fix history when manager is closed
@peuter peuter added bug / bugfix manager needs-to-be-cherry-picked This PR needs to be cherry picked to the lateste release branch after it hast been merged labels Feb 26, 2022
@peuter peuter added this to the 0.12.0 milestone Feb 26, 2022
@ChristianMayer ChristianMayer merged commit f4e2765 into CometVisu:develop Feb 27, 2022
@ChristianMayer ChristianMayer added was-cherry-picked DONE: This PR needed to be cherry picked to the lateste release branch after it hast been merged and removed needs-to-be-cherry-picked This PR needs to be cherry picked to the lateste release branch after it hast been merged labels Mar 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristianMayer ChristianMayer ChristianMayer approved these changes

Assignees
No one assigned
Labels
bug / bugfix manager was-cherry-picked DONE: This PR needed to be cherry picked to the lateste release branch after it hast been merged
Projects
None yet
Milestone
0.12.0
Development

Successfully merging this pull request may close these issues.
2 participants
@peuter @ChristianMayer