Use AppNotificationManager instead of ToastNotificationManager #900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfversluis
previously approved these changes
Jan 17, 2023
Co-authored-by: Gerald Versluis <gerald@verslu.is>
pictos
requested changes
Jan 17, 2023
…it/Maui into Toast-Use-New-API
pictos
approved these changes
Jan 17, 2023
brminnick
reviewed
Jan 17, 2023
| string text = string.Empty; | ||
| string actionButtonText = AlertDefaults.ActionButtonText; | ||
| readonly string text = string.Empty; | ||
| readonly string actionButtonText = AlertDefaults.ActionButtonText; |
There was a problem hiding this comment.
Cool!! I didn't know that we could use readonly fields in get; init; properties!
I like it. It makes a lot of sense 💯
brminnick
reviewed
Jan 17, 2023
| /// </summary> | ||
| /// <param name="text">Notification text</param> | ||
| /// <returns><see cref="XmlDocument"/></returns> | ||
| public static XmlDocument BuildToastNotificationContent(string text) |
There was a problem hiding this comment.
FYI - this is technically a breaking change, removing a public API
We'll need to bump our Major version number for our next release (which'll hopefully coincide with the release of MediaPlayer)
There was a problem hiding this comment.
That being said, I'd be surprised if removing this API impacts any devs
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Update Toast Windows to use the new API AppNotificationManager as Microsoft recommends: https://learn.microsoft.com/en-us/windows/apps/design/shell/tiles-and-notifications/adaptive-interactive-toasts?tabs=appsdk
PR Checklist
approved(bug) orChampioned(feature/proposal)mainat time of PRAdditional information