Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to issue #4316 - error in duration to frequency calculation. #4317

Merged
merged 1 commit into from
Oct 14, 2021

Conversation

peteams
Copy link
Contributor

@peteams peteams commented Oct 13, 2021

Closes #4316.

Fixes

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • New component
    • Pull Request has been submitted to the documentation repository instructions. Link:
    • Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that)
    • If control, added to Visual Studio Design project
  • Sample in sample app has been added / updated (for bug fixes / features)
  • New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

@ghost
Copy link

ghost commented Oct 13, 2021

Thanks peteams for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost requested review from michael-hawker and azchohfi October 13, 2021 18:56
@ghost ghost added the bug 🐛 An unexpected issue that highlights incorrect behavior label Oct 13, 2021
@michael-hawker michael-hawker added this to the 7.1.1 milestone Oct 13, 2021
@michael-hawker michael-hawker merged commit afebbd3 into main Oct 14, 2021
@delete-merged-branch delete-merged-branch bot deleted the petea/issue/4316 branch October 14, 2021 20:37
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 An unexpected issue that highlights incorrect behavior gaze 👀
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OneEuroFilter incorrectly translates from duration to frequency.
3 participants