Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed broken example code in AnimationBuilder.Create docs #4392

Merged

Conversation

Arlodotexe
Copy link
Member

@Arlodotexe Arlodotexe commented Nov 22, 2021

Fixes

Fixes a broken code example in the documentation for the AnimationBuilder.Create() method.

PR Type

What kind of change does this PR introduce?

  • Documentation content changes

What is the current behavior?

https://docs.microsoft.com/en-us/dotnet/api/microsoft.toolkit.uwp.ui.animations.animationbuilder?view=win-comm-toolkit-dotnet-7.0

image

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • New component
    • Pull Request has been submitted to the documentation repository instructions. Link:
    • Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that)
    • If control, added to Visual Studio Design project
  • Sample in sample app has been added / updated (for bug fixes / features)
  • New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

@ghost
Copy link

ghost commented Nov 22, 2021

Thanks Arlodotexe for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost requested review from michael-hawker and azchohfi November 22, 2021 12:07
@XAML-Knight
Copy link
Contributor

PR looks like a good idea, but it's opened up a new error with our build system's code analysis (error SA1028).

Co-authored-by: Michael Hawker MSFT (XAML Llama) <24302614+michael-hawker@users.noreply.github.com>
@Arlodotexe Arlodotexe merged commit 62c4934 into CommunityToolkit:main Dec 17, 2021
@Arlodotexe Arlodotexe deleted the animationsbuilder-docs-example-fix branch December 17, 2021 21:54
@michael-hawker michael-hawker added this to the 8.0 milestone Dec 17, 2021
@michael-hawker michael-hawker modified the milestones: 8.0, 7.1.3 Jul 14, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants