Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed InAppNotification not dismissing programmatically after cancelling closing event #4424

Merged
1 commit merged into from
Jan 20, 2022

Conversation

Arlodotexe
Copy link
Member

Fixes #4423

PR Type

What kind of change does this PR introduce?

Bugfix

What is the current behavior?

When the Closing event is cancelled, subsequent calls to Dismiss() no longer work as expected.

What is the new behavior?

Fixed an issue where InAppNotification couldn't be dismissed programmatically after cancelling the closing event.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • New component
    • Pull Request has been submitted to the documentation repository instructions. Link:
    • Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that)
    • If control, added to Visual Studio Design project
  • Sample in sample app has been added / updated (for bug fixes / features)
  • New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

@Arlodotexe Arlodotexe added bug 🐛 An unexpected issue that highlights incorrect behavior hotfix 🌶 labels Dec 14, 2021
@ghost
Copy link

ghost commented Dec 14, 2021

Thanks Arlodotexe for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost requested a review from azchohfi December 14, 2021 01:47
@ghost ghost added the controls 🎛️ label Dec 14, 2021
@michael-hawker michael-hawker added this to the 8.0 milestone Jan 19, 2022
@ghost
Copy link

ghost commented Jan 19, 2022

Hello @michael-hawker!

Because this pull request has the auto merge :zap: label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@michael-hawker
Copy link
Member

@msftbot merge if @vgromfeld approves

@ghost
Copy link

ghost commented Jan 19, 2022

Hello @michael-hawker!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I'll only merge this pull request if it's approved by @vgromfeld

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@ghost ghost merged commit b751d87 into CommunityToolkit:main Jan 20, 2022
@michael-hawker michael-hawker modified the milestones: 8.0, 7.1.3 Jul 14, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto merge ⚡ bug 🐛 An unexpected issue that highlights incorrect behavior controls 🎛️ hotfix 🌶
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InAppNotification can no longer be dismissed after canceling the Closing event
4 participants