Fixed left/right key input for Carousel in RTL Flow Direction #4518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Avid29 for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
ghost
requested review from
ghost
added
the
Arlodotexe
approved these changes
Mar 25, 2022
LalithaNadimpalli
approved these changes
Aug 3, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4517
Fixes the scroller direction of carousel items in RTL Flow Direction
PR Type
What kind of change does this PR introduce?
Bugfix
What is the current behavior?
In RTL flow direction right key/gamepad presses scroll the carousel in the inverted direction
What is the new behavior?
Flow Direction is checked before position increment or decrement on left/right key/gamepad presses.
PR Checklist
Please check if your PR fulfills the following requirements:
Other information