-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compass overwrites image_url from sass-rails #500
Comments
this is a known issue and chris is "working on it" |
If it's of any help, requiring |
Indeed; sass-rails just overwrites the method. Thanks for the suggestion in On Fri, Aug 5, 2011 at 12:56 AM, spohlenz <
|
the issue is that compass and sass-rails image_url helpers take different arguments. compass needs to be able to detect if sass-rails is loaded and alias the functions |
@spohlenz and how do you achieve |
@huerlisi an initializer is probably to late in the boot process. Try putting the requires directly in |
@spohlenz thanks, works now! |
@huerlisi, can you explain what you did exactly? I added |
@johnnym, just realizing that I had to play a bit with |
Thanks! The cache was the problem. I would have expected it to have been rebuilt automatically since I changed all the |
Just to warn you all the above solution is not the correct one it may make it work but the compass and sass-rails helpers take different arguments so down the line once this is fixed you will have to refactor. https://github.com/rails/sass-rails/blob/master/lib/sass/rails/helpers.rb#L13 |
Any updates on this issue? |
Chris wants to do a alpha this week I think Sent from my iPhone On Aug 25, 2011, at 12:23 PM, dfischerreply@reply.github.com wrote:
|
See also: #519. Probably the same issue, but none of the fixes in this thread have worked for me. |
For the folks who need a fix "yesterday", I can still manage to get around the issue (in what I hope is a forwards-compatible way) by using an ERB stylesheet instead. So, I still have the old included stylesheet:
But then, I've just added a line to "application.css.scss.erb" (rename if necessary):
In some future point when this gets fixed, I can remove the line from application.css or even just leave it as is and it should work. |
works more simply with
only the image_url function seems to be affected |
this should be fixed in the current alpha |
I wanted to add compass to an existing Rails 3.1.0.rc5 app that I have. I added the gem to the Gemfile, and used Ken Collins' fix to get the asset pipeline to recognize the compass framework stylesheets.
However, in the process of doing so, compass seemed to overwrite the recently-introduced image_url helper from sass-rails, which would break the links to precompiled assets in the production environment (it would link to /assets/my.png?12345 rather than /assets/my-12345.png)
The text was updated successfully, but these errors were encountered: