Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for reset-baseline() in vertical_rhythm partial #791

Closed
wants to merge 1 commit into from
Closed

Update docs for reset-baseline() in vertical_rhythm partial #791

wants to merge 1 commit into from

Conversation

JohnAlbin
Copy link
Contributor

Over in #780 the decision was made to deprecate the reset-baseline() partial in the master branch that will be Compass 0.13 (which I did in #790).

But we still need to better document that mixin in the stable 0.12 branch.

Here's a better description of the mixin with a mild warning about it not working in all circumstances.

@ry5n
Copy link
Contributor

ry5n commented Mar 14, 2012

@JohnAlbin +1, although I'd make it clear why it won't work and when: “does not work on elements whose font-size is different from $base-font-size”

@scottdavis
Copy link
Member

Go ahead and fix the typo and just make it @include adjust-leading-to(1, $base-font-size); and put a @warn in there and ill merge this in.

@chriseppstein
Copy link
Member

I took @ry5n's feedback into account -- this is on stable now as 3f96108 and 1aca960

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants