IE7 requires html { font-size: 100%; } in establish-baseline() #1520
Conversation
|
Here's a more recent reference that shows it's both IE 6 and IE 7 that need the percent font. |
| @@ -95,16 +95,15 @@ $relative-font-sizing: if($rhythm-unit == px, false, true); | |||
|
|
|||
| // Establishes a font baseline for the given font-size. | |||
| @mixin establish-baseline($font-size: $base-font-size) { | |||
| $relative-size: 100% * ($font-size / $browser-default-font-size); | |||
There was a problem hiding this comment.
Why was this line removed? $relative-size is still called on line 99, and now throws an error in the tests. This line should stay and be added to the new line 105 as well. No reason to duplicate that math.
|
Thanks @JohnAlbin! Can you fix the broken variable, and get the tests passing? There are instructions for writing and running the tests in CONTRIBUTING.md file. |
|
Ok. The tests are "fixed". Except that they are still being reported as broken because the new tests depend on #1524, so that we can actually test when IE7 support is turned off. |
|
#1524 was rejected, so can we get this rebased off of master? |
|
I mean stable. |
I was checking out the updated vertical-rhythm module and saw that
* html { font-size: 100%; }is only added for IE 6. I seemed to remember that IE 7 also required that. So I looked it up…IE 6 and 7 cannot resize fonts set with px. http://alistapart.com/article/howtosizetextincss#section3
IE 6 and 7 resize fonts weirdly when set with em. http://alistapart.com/article/howtosizetextincss#section4
Since IE7 doesn't understand the
* htmlselector hack, we have to switch to the*propertyhack that both IE 6 and IE 7 know (but IE 8 and above do not.)