Add $offset parameter to rhythm() function. #848
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was writing a mixin that needed to subtract a couple pixels from the vertical rhythm margin, just like the rhythm borders mixins do.
And then I noticed the math the rhythm border mixins are using is almost identical to the math in the
rhythm()
function.Keeping with DRY, I'd like to propose we add an $offset parameter to the
rhythm()
function.Then I can use
rhythm()
in my mixin instead of copy/pasting/rewriting lines of code from the rhythm borders mixins.Note that the $offset parameter is totally backwards compatible with existing usage of the
rhythm()
function. No one's existing Sass should be affected.