Fix install_vm.py on older versions of Python #10651
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We will remove the type hints that use collections. According to https://peps.python.org/pep-0585/, the "Type Hinting Generics In Standard Collections" were introduced in Python 3.9, but RHEL 8 and 7 use Python 3.6. Fixes: ComplianceAsCode#10650
jan-cerny
added
the
backported-into-stabilization
|
Start a new ephemeral environment with changes proposed in this pull request: Fedora Environment Oracle Linux 8 Environment |
|
Code Climate has analyzed commit c6c31d2 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 52.5% (0.0% change). View more on Code Climate. |
|
LGTM |
jan-cerny
added a commit
to jan-cerny/scap-security-guide
that referenced
this pull request
May 30, 2023
We will remove the type hints that use collections. According to https://peps.python.org/pep-0585/, the "Type Hinting Generics In Standard Collections" were introduced in Python 3.9, but RHEL 8 and 7 use Python 3.6. This is a backport of ComplianceAsCode#10651. Fixes: ComplianceAsCode#10650
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We will remove the type hints that use collections. According to https://peps.python.org/pep-0585/, the "Type Hinting Generics In Standard Collections" were introduced in Python 3.9, but RHEL 8 and 7 use Python 3.6.
Fixes: #10650