Stabilization: Fix install_vm.py on older versions of Python #10652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-cerny
added
BLOCKER
|
Start a new ephemeral environment with changes proposed in this pull request: Fedora Environment Oracle Linux 8 Environment |
|
/packit copr-build |
|
Tested, work fine. Can be merged when |
jan-cerny
force-pushed
the
issue10650_stabilization
branch
from
62143f6
to
9f1f86b
Compare
We will remove the type hints that use collections. According to https://peps.python.org/pep-0585/, the "Type Hinting Generics In Standard Collections" were introduced in Python 3.9, but RHEL 8 and 7 use Python 3.6. Fixes: ComplianceAsCode#10650
jan-cerny
force-pushed
the
issue10650_stabilization
branch
from
9f1f86b
to
8d2c47d
Compare
vojtapolasek
merged commit d43223b
into
ComplianceAsCode:stabilization-v0.1.68
22 of 26 checks passed
jan-cerny
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We will remove the type hints that use collections. According to https://peps.python.org/pep-0585/, the "Type Hinting Generics In Standard Collections" were introduced in Python 3.9, but RHEL 8 and 7 use Python 3.6.
Fixes: #10650
This is a backport of #10651 to the stabilization branch.