Sanitize lines for clean YAML output when generating profiles #10870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Start a new ephemeral environment with changes proposed in this pull request: Fedora Environment Oracle Linux 8 Environment |
Mab879
approved these changes
Jul 19, 2023
Mab879
requested changes
Jul 19, 2023
There is an issue with how pyyaml dumps lines, where if the line ends with whitespace, styling won't matter. yaml/pyyaml#121 This was affecting our ability to generate YAML output where audit procedures (with many long lines) would get rendered as a single line with escaped newlines. Instead, we want to render newlines as a block. This commit parse each line of the data before it is dumped to make sure trailing whitespace is removed as a workaround for this issue in pyyaml.
rhmdnd
force-pushed
the
sanitize-yaml-lines-for-generate-profile-script
branch
from
55d3ce6
to
58922f0
Compare
|
Code Climate has analyzed commit 58922f0 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 53.2% (0.0% change). View more on Code Climate. |
|
/packit retest-failed |
|
/packit rebuild-failed |
Mab879
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an issue with how pyyaml dumps lines, where if the line ends
with whitespace, styling won't matter.
yaml/pyyaml#121
This was affecting our ability to generate YAML output where audit
procedures (with many long lines) would get rendered as a single line
with escaped newlines. Instead, we want to render newlines as a block.
This commit parse each line of the data before it is dumped to make sure
trailing whitespace is removed as a workaround for this issue in pyyaml.