Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove OVAL version restrictions from auditd_audispd_configure_sufficiently_large_partition #11816

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Remove OVAL version restrictions from auditd_audispd_configure_sufficiently_large_partition #11816

merged 1 commit into from
Apr 17, 2024

Conversation

Mab879
Copy link
Member

@Mab879 Mab879 commented Apr 12, 2024

Description:

Remove OVAL version restrictions from auditd_audispd_configure_sufficiently_large_partition

Rationale:

Fixes #11802

@github-actions GitHub Actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@github-actions GitHub Actions
Copy link

This datastream diff is auto generated by the check Compare DS/Generate Diff

Click here to see the full diff 
New data stream adds OVAL for rule 'xccdf_org.ssgproject.content_rule_auditd_audispd_configure_sufficiently_large_partition'.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 12, 2024 •
edited

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:11816
This image was built from commit: 877951f

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:11816

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:11816 make deploy-local

@jan-cerny jan-cerny self-assigned this Apr 15, 2024
@jan-cerny
Copy link
Collaborator

/packit build

@jan-cerny jan-cerny added this to the 0.1.73 milestone Apr 15, 2024
@jan-cerny jan-cerny added OVAL OVAL update. Related to the systems assessments. bugfix Fixes to reported bugs. labels Apr 15, 2024
@Mab879
Copy link
Member Author

Mab879 commented Apr 15, 2024

/packit build

jan-cerny
jan-cerny reviewed Apr 16, 2024
View reviewed changes
Copy link
Collaborator

@jan-cerny jan-cerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase this on the top of latest master because of the sssd_enable_pam_services problem. Otherwise the change looks good to me.

@jan-cerny
Copy link
Collaborator

/retest

@codeclimate CodeClimate
Copy link

codeclimate bot commented Apr 17, 2024

Code Climate has analyzed commit 877951f and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.2% (0.0% change).

View more on Code Climate.

@jan-cerny jan-cerny merged commit 0817ec8 into ComplianceAsCode:master Apr 17, 2024
45 checks passed
@Mab879 Mab879 deleted the fix_11802 branch April 17, 2024 12:21
@marcusburghardt marcusburghardt mentioned this pull request Apr 25, 2024
Closed
@Mab879 Mab879 mentioned this pull request Apr 26, 2024
Draft
marcusburghardt added a commit to marcusburghardt/content that referenced this pull request Apr 30, 2024
@marcusburghardt
Revert PR 11816
6169ef5 
Thanks to ComplianceAsCode#11816 it were releaved more issues related to OVAL version.
After discussions in ComplianceAsCode#11903 it was concluded to revert this change for
now so we can better work a long-term solution.
marcusburghardt added a commit to marcusburghardt/content that referenced this pull request Apr 30, 2024
@marcusburghardt
Revert PR 11816
0c84f81 
Thanks to ComplianceAsCode#11816 it were revealed more issues related to OVAL version.
After discussions in ComplianceAsCode#11903 it was concluded to revert this change for
now so we can better work a long-term solution.
This was referenced Apr 30, 2024
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-cerny jan-cerny jan-cerny approved these changes

Assignees

@jan-cerny jan-cerny

Labels
bugfix Fixes to reported bugs. OVAL OVAL update. Related to the systems assessments.
Projects
None yet
Milestone
0.1.73
Development

Successfully merging this pull request may close these issues.

CCE-88173-0 is notchecked by SSG, however for DISA STIG it fail
2 participants
@Mab879 @jan-cerny