Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert PR 11816 #11917

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Revert PR 11816 #11917

merged 1 commit into from
Apr 30, 2024

Conversation

marcusburghardt
Copy link
Member

Description:

Thanks to #11816 it were revealed more issues related to OVAL version.
After discussions in #11903 it was concluded to revert this change for now so we can better work a long-term solution.

Rationale:

@marcusburghardt
Revert PR 11816
0c84f81 
Thanks to ComplianceAsCode#11816 it were revealed more issues related to OVAL version.
After discussions in ComplianceAsCode#11903 it was concluded to revert this change for
now so we can better work a long-term solution.
@marcusburghardt marcusburghardt added bugfix Fixes to reported bugs. OVAL OVAL update. Related to the systems assessments. labels Apr 30, 2024
@marcusburghardt marcusburghardt added this to the 0.1.73 milestone Apr 30, 2024
@github-actions GitHub Actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@marcusburghardt marcusburghardt mentioned this pull request Apr 30, 2024
Open
@github-actions GitHub Actions
Copy link

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:11917
This image was built from commit: 0c84f81

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:11917

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:11917 make deploy-local

@codeclimate CodeClimate
Copy link

codeclimate bot commented Apr 30, 2024

Code Climate has analyzed commit 0c84f81 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

@vojtapolasek vojtapolasek self-assigned this Apr 30, 2024
vojtapolasek
vojtapolasek approved these changes Apr 30, 2024
View reviewed changes
Copy link
Collaborator

@vojtapolasek vojtapolasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the rule auditd_audispd_configure_sufficiently_large_partition is reported as not checked now.

@vojtapolasek vojtapolasek merged commit c6b5d1d into ComplianceAsCode:master Apr 30, 2024
113 checks passed
@marcusburghardt marcusburghardt deleted the revert_11816 branch April 30, 2024 09:19
@marcusburghardt marcusburghardt mentioned this pull request Apr 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vojtapolasek vojtapolasek vojtapolasek approved these changes

@Mab879 Mab879 Awaiting requested review from Mab879

@jan-cerny jan-cerny Awaiting requested review from jan-cerny

Assignees

@vojtapolasek vojtapolasek

Labels
bugfix Fixes to reported bugs. OVAL OVAL update. Related to the systems assessments.
Projects
None yet
Milestone
0.1.73
Development

Successfully merging this pull request may close these issues.

auditd_audispd_configure_sufficiently_large_partition reports unknown after #11816
2 participants
@marcusburghardt @vojtapolasek