Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add namespace parameter for cluster-test #11824

Merged

Conversation

sluetze
Copy link
Contributor

@sluetze sluetze commented Apr 16, 2024

Description:

this pr adds the ability to define a --namespace parameter for cluster-test in add_kubernetes_rule.py and defines "openshift-compliance" as default

Rationale:

while running ./utils/add_kubernetes_rule.py cluster-test --rule kubelet_anonymous_auth there were sometimes empty results.

* Running scan with rule 'kube_descheduler_operator_exists'
> Output from last phase check: <no value> <no value>
[ ... ]
> Output from last phase check: <no value> <no value>
> Output from last phase check: <no value> <no value>
ERROR: Timeout waiting for scan to finish

this was caused by not switching to openshift-compliance namespace before running the command. To fix this I added a --namespace with openshift-compliance as default.

Review Hints:

deployments with non default namespace (not openshift-compliance) have a workflow impact.
before:
oc project $namespace
./utils/add_kubernetes_rule.py cluster-test --rule kubelet_anonymous_auth

after:
./utils/add_kubernetes_rule.py cluster-test --rule kubelet_anonymous_auth --namespace $namespace

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Used by openshift-ci bot. label Apr 16, 2024
@sluetze sluetze marked this pull request as ready for review April 16, 2024 13:13
@openshift-ci openshift-ci bot added needs-ok-to-test Used by openshift-ci bot. and removed do-not-merge/work-in-progress Used by openshift-ci bot. labels Apr 16, 2024
Copy link

openshift-ci bot commented Apr 16, 2024

Hi @sluetze. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

github-actions bot commented Apr 16, 2024

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:11824
This image was built from commit: 66f77d0

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:11824

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:11824 make deploy-local

Copy link

codeclimate bot commented Apr 16, 2024

Code Climate has analyzed commit bc391ce and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.2% (0.0% change).

View more on Code Climate.

@marcusburghardt marcusburghardt added the Kubernetes Kubernetes remediation update. label Apr 17, 2024
@yuumasato yuumasato self-assigned this Jun 10, 2024
@yuumasato yuumasato added this to the 0.1.74 milestone Jun 10, 2024
Copy link
Member

@yuumasato yuumasato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this improvement.
I have just a small request.

utils/add_kubernetes_rule.py Outdated Show resolved Hide resolved
Co-authored-by: Watson Yuuma Sato <wsato@redhat.com>
@yuumasato
Copy link
Member

Skipping Ansible hardening tests.

@yuumasato yuumasato merged commit 7fe69e7 into ComplianceAsCode:master Jun 11, 2024
35 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Kubernetes Kubernetes remediation update. needs-ok-to-test Used by openshift-ci bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants