-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend the Profile class in profile_tool #12019
Extend the Profile class in profile_tool #12019
Conversation
I had to conduct some tests with variables in profiles and it became much easier when this class was expanded to also map variables instead of only rules. It was actually considered when the class was introduced but there was no concrete demand for this back in the time. Now there is a demand for assessment of profiles variables.
🤖 A k8s content image for this PR is available at: Click here to see how to deploy itIf you alread have Compliance Operator deployed: Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the changes, but I have one suggestion regarding profile variables.
It will improve the performance when interacting with profile variables.
Code Climate has analyzed commit 67365a7 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 59.4% (0.0% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description:
I had to conduct some tests with variables in profiles and it became much easier when this class was expanded to also map variables instead of only rules. It was actually considered when the class was introduced but there was no concrete demand for this back in the time. Now there is a demand for assessment of profiles variables.
Rationale:
Much easier to assess profiles.
Review Hints:
Some small tests to make sure the existing behavior of profile_tool is not changed should be enough. e.g.: