Ensure default value in variables #12020
Conversation
Ensure a default value so it doesn't fail if an explicit definition is absent.
….var Ensure a default value so it doesn't fail if an explicit definition is absent. This variable is explicitly used by many products. The default value was based on current values for rhel9. It is just for reference and to not fail. Specific products should review their own values.
|
Start a new ephemeral environment with changes proposed in this pull request: Fedora Environment Oracle Linux 8 Environment |
|
🤖 A k8s content image for this PR is available at: Click here to see how to deploy itIf you alread have Compliance Operator deployed: Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and: |
|
Code Climate has analyzed commit 15faa0b and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 59.4% (0.0% change). View more on Code Climate. |
|
@marcusburghardt Can we have some test or build-time check that would prevent this situation? For example I think that when the build system loads a variable from YAML file it could check that it contains the "default" key. |
Hi @marcusburghardt , I plan to introduce a test for this after the #12019. It is already in my list here but I would prefer to introduce it later in a different PR, ok? |
Description:
During some tests it was found two variables without a default value.
Ensure a default value based on existing options.
Rationale:
All variables have a default value.