Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent user from disabling the screen lock. #4742

Merged
merged 1 commit into from
Aug 19, 2019

Conversation

adelton
Copy link
Collaborator

@adelton adelton commented Aug 19, 2019

Description:

  • Prevent user from disabling the screen lock.

Rationale:

  • Not listing tmux among permitted shells prevents malicious program running as user from lowering security by disabling the screen lock.

@adelton
Copy link
Collaborator Author

adelton commented Aug 19, 2019

Rebased on master -> d33a304.

@mildas mildas self-assigned this Aug 19, 2019
@jan-cerny
Copy link
Collaborator

@adelton You usually add rules also to Fedora profile, why not this time?

@adelton
Copy link
Collaborator Author

adelton commented Aug 19, 2019

The configure_bashrc_exec_tmux (which this one is copy of) did not have it either. That one is a copy of configure_tmux_lock_after_time which is a copy of configure_tmux_lock_command which finally is a rule that I did not author, and it does not have Fedora as well.

@mildas
Copy link
Contributor

mildas commented Aug 19, 2019

People can tailor Fedora profile with these tmux rules. If we would want them in, we can add them all together. Right now it would be mess, if we add this rule to the profile and other tmux rules wouldn't be there.
This PR LGTM and if you want tmux rules in Fedora profile, add them all together in new PR. Thank you

@mildas mildas merged commit d234339 into ComplianceAsCode:master Aug 19, 2019
@yuumasato yuumasato added this to the 0.1.46 milestone Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants