postfix_network_listening_disabled tests #6708
Conversation
mildas
force-pushed
the
postfix_network_tests
branch
from
ada55e9
to
5f27c89
Compare
| @@ -1,4 +1,6 @@ | |||
| #!/bin/bash | |||
| # packages = postfix | |||
|
|
|||
| echo "inet_interfaces = some_different_interface,loopback-only" > /etc/postfix/main.cf | |||
There was a problem hiding this comment.
I see value in testing if a correct substring is not mistaken as a correct configuration, the rule description mentions that the only value configured should be the one from the variable.
There was a problem hiding this comment.
I see that the original test "tested" two things at the same time, so it could be put into a test scenario of its own.
There was a problem hiding this comment.
That's a good point. I have added a new test scenario similar to the previous one.
Unfortunately, in the new test scenario, I have to start postfix first and then add the configuration. It's because having inet_interfaces = some_different_interface,loopback-only requires to have interface called loopback-only. Without that, you can't start postfix.
mildas
force-pushed
the
postfix_network_tests
branch
from
5f27c89
to
61dcf37
Compare
|
@mildas: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Description:
Add a new test scenario and fix existing ones. The existing ones didn't work as expected because when
postfixis not running, the/etc/postfix/main.cffile is not checked at all.