New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
postfix_network_listening_disabled tests #6708
Merged
yuumasato
merged 1 commit into
ComplianceAsCode:master
from
mildas:postfix_network_tests
Mar 17, 2021
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 3 additions & 1 deletion
4
...guide/services/mail/postfix_client/postfix_network_listening_disabled/tests/wrong.fail.sh
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,6 @@ | ||
#!/bin/bash | ||
# packages = postfix | ||
|
||
echo "inet_interfaces = some_different_interface,loopback-only" > /etc/postfix/main.cf | ||
echo "inet_interfaces = all" > /etc/postfix/main.cf | ||
systemctl enable postfix | ||
systemctl start postfix |
6 changes: 6 additions & 0 deletions
6
...es/mail/postfix_client/postfix_network_listening_disabled/tests/wrong_and_correct.fail.sh
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
#!/bin/bash | ||
# packages = postfix | ||
|
||
systemctl enable postfix | ||
systemctl start postfix | ||
echo "inet_interfaces = all,loopback-only" > /etc/postfix/main.cf |
6 changes: 6 additions & 0 deletions
6
...s/mail/postfix_client/postfix_network_listening_disabled/tests/wrong_but_disabled.pass.sh
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
#!/bin/bash | ||
# packages = postfix | ||
|
||
echo "inet_interfaces = all" > /etc/postfix/main.cf | ||
systemctl stop postfix | ||
systemctl disable postfix |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see value in testing if a correct substring is not mistaken as a correct configuration, the rule description mentions that the only value configured should be the one from the variable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that the original test "tested" two things at the same time, so it could be put into a test scenario of its own.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good point. I have added a new test scenario similar to the previous one.
Unfortunately, in the new test scenario, I have to start postfix first and then add the configuration. It's because having
inet_interfaces = some_different_interface,loopback-only
requires to have interface calledloopback-only
. Without that, you can't start postfix.