install_vm.py: add possibility to install GUI system #7004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also updated kickstart file as `install` command has been deprecated in Fedora 34: https://docs.fedoraproject.org/my/fedora/f34/release-notes/sysadmin/Installation/#sect-kickstart-deprecated-removed
|
Hello @matusmarhefka! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:
|
|
Changes identified: Show detailsOthers: Recommended tests to execute: |
|
/retest |
|
Works amazing, I was able to install a F34 VM with GUI. |
vojtapolasek
pushed a commit
that referenced
this pull request
May 24, 2021
install_vm.py: add possibility to install GUI system (cherry picked from commit e92a835)
vojtapolasek
added
the
backported-into-stabilization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces
--install-guioption into theinstall_vm.pyscript so it is easy to test also installations with GUI.Additional changes:
install_vm.pyscript to Fedora 34installcommand has been deprecated in Fedora 34 - https://docs.fedoraproject.org/my/fedora/f34/release-notes/sysadmin/Installation/#sect-kickstart-deprecated-removed/usr,/opt,/srv) so the kickstart is compatible with all Fedora/RHEL profiles (/usrpartition has increased size to be able to install Fedora 34 with GUI)I have tested both installations, with and without GUI, for the following: