Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated install command from RHEL8 kickstarts #7065

Merged
merged 2 commits into from
Jun 8, 2021

Conversation

matusmarhefka
Copy link
Member

@matusmarhefka matusmarhefka commented Jun 1, 2021

Description:

  • Remove deprecated install command from RHEL8 kickstarts, Anaconda prints the following warning when installing RHEL8:
    The install command has been deprecated and no longer has any effect.
    It may be removed from future releases, which will result in a fatal
    error from kickstart.  Please modify your kickstart file to remove
    this command.

There is one more warning from Anaconda about authconfig:

org.fedoraproject.Anaconda.Modules.Security[1733]: INFO:program:IMPORTANT: authconfig is replaced by authselect, please update your scripts.

but I am not sure if we can just replace authconfig with authselect as there might be also some rules in profiles
which would need the similar update. This needs more investigation (outside of this PR).

For RHEL8 min. memory is 1.5 GB per logical CPU core:
https://access.redhat.com/articles/rhel-limits
Anaconda prints the following warning when installing RHEL8:

The install command has been deprecated and no longer has any effect.
It may be removed from future releases, which will result in a fatal
error from kickstart.  Please modify your kickstart file to remove
this command.
@matusmarhefka matusmarhefka added this to the 0.1.57 milestone Jun 1, 2021
@openscap-ci
Copy link
Collaborator

Changes identified:
Others:
 Changes in Python files.

Show details

Others:
 Python abstract syntax tree change found in tests/install_vm.py.

Recommended tests to execute:
 (cd build && cmake ../ && ctest -j4)

@JAORMX
Copy link
Contributor

JAORMX commented Jun 2, 2021

/retest

@vojtapolasek vojtapolasek self-assigned this Jun 4, 2021
@vojtapolasek
Copy link
Collaborator

Looks good, thank you. Just a question, are you going to solve this somehow also for the kickstart used for installing of test machines?

@matusmarhefka
Copy link
Member Author

@vojtapolasek KS for test suite has already been updated in #7004

@vojtapolasek
Copy link
Collaborator

I see. Merging.

@vojtapolasek vojtapolasek merged commit 478267a into ComplianceAsCode:master Jun 8, 2021
@matusmarhefka matusmarhefka deleted the ks_update branch June 10, 2021 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants