feat: upgrade to official upstream pfm module instead of notional copy paste #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dzmitry-lahoda -- the copy paste you mentioned has additional support for types that are only present in composable. Wdyt? |
faddat
suggested changes
Jan 1, 2024
There was a problem hiding this comment.
I think this might not be a good idea:
cosmos/ibc-apps@main...notional-labs:ibc-apps:faddat/update-tweaked-pfm
The way that I handled it was to take the differences and then merge main into them.
|
@dzmitry-lahoda you're aware the notional one isn't preciesly a copy paste right? eg: it added some dot-specfic features that from my read of things, likely matter a bunch. |
|
i am aware. my point is that likely no fork needed if middleware stack composition used. |
|
@dzmitry-lahoda yeah that makes sense |
|
will keep branch:) |
|
sorry, let restored |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on #394