Skip to content

Commit

Permalink
parent 62f6e5b
Browse files Browse the repository at this point in the history
author Hussein Ait-Lahcen <hussein.aitlahcen@gmail.com> 1640264806 +0100
committer Ben Luelo <benluelo@hotmail.com> 1641229158 -0500
gpgsig -----BEGIN PGP SIGNATURE-----

 iQGzBAABCgAdFiEEvcJAWzQ+hHD6e6hZKDJl/2mUhmAFAmHTK2YACgkQKDJl/2mU
 hmAZUgv/YlQbIMXV8utYIgxSDSTAGtW4Ruo5bXSQzDQJWKL8AMk04WJs/A2YgsV4
 v7COvbFaTEKM0BrfAbSd8RhGUI2xQmTtvzr3M7dXhTPh6UIRK1O2QU62XBwFlRiG
 m40HoP+FHnhdMeO49jiD+6JiJQZJ4YysLw3TpF4NMCLLAE+OEVUkTHkbovrawfte
 zPrw2suOz4PIhajPKlThPsyec7GfnLTRZFZcsjovSerI+BYUBIroCWtoLP3Hw873
 nCdve/HigNfwyeFVVw61coa8csqzN8CA2qzg2AFAHfsvNBil8baFJMywm+6vfV7s
 qnN+XK/GgrYZew5V00vNhKmW8h7/K0Gdyeuri/LelokXNE/PGiRrODl+066F/qCN
 U6urzh2nny1lTsbIoVMnOryk5yj3ekFd8Nsy/SmFtaGFjRvErdtZ0Qzd3zENVxie
 YCb4Msgce3UgZbQ8wLo3RaQKg+32i562ewDyWtnATG+CY+jCWeRlAqHYakTKzRrn
 91xqAEMi
 =4XKn
 -----END PGP SIGNATURE-----

CU-1kr4tya - Crowdloan rewards benchmarking (#412)

* CU-1kr4tya - crowdloan rewards benchmarking

* fix main benchmarking

* add crowdloan-rewards to runtime and generated benchmark weights

* update cargo lock

* refactor crowdloan rewards test to use 1:1 benchmarking types

* fix populate weight calculation

* make sure to remove rewards prior to populate

* use runtime prefix in benchmarking

* unused dependency

Run benchmark for develop and fix `cargo vendor` (#419)

CU-1wtx9fb Implement Constant Product AMM.

Democracy (#389)

* CU-1rpbzkw - democracy pallet

Fixed missing test cases and related dependencies

Added missing test cases

Fixed format errors and docs

Fixing docs

 CU-1rpbzkw | Fixed failing test case

CU-1rpbzkw | handle transfer_held() result

CU-1rpbzkw | added few more multi currency tests

CU-1rpbzkw | fixing fmt

Changes & fixes for benchmarking

Linting fixes

* Democracy

Co-authored-by: kaiserkarel <k.l.kubat@gmail.com>

split out dali runtime from picasso (#421)

* split out dali runtime from picasso

* cargo fm

* fix runtimes

* cargo fmt

[BondedFinance] Add benchmarks (#377)

Add email (#431)

Add rust-toolchain.toml (#435)

* Add rust-toolchain.toml
* Remove ConvertInto import

Fix clippy lints

cargo fmt

Add clippy::indexing_slicing annotation to all crates

Fix slicing warnings in curve-amm crate.

I wasn't able to fix all of the occurences or slicing; some functions take indexes directly. I feel like these should be using .get(n) and returning some sort of dispatch error instead of panicking, but I'm not knowledgeable enough about substrate to say for sure. All instances of this have been annoted with a `REVIEW: indexing` comment at the function level.

Fix and/or audit indexing warninggs in oracle crate

Fix and/or audit indexing in oracle crate

Fix bug in add_liquidity

Add type annotation

Style & formatting

Fix extra underscore in integer literal

Add clippy::disallowed_type lint

Change MockCurrencyId variants to be CONSTANT_CASE

Remove uses of dbg!() macro

rustfmt

CU-1p8545r  dutch auction (#410)

* dutch auction

Signed-off-by: dzmitry-lahoda <dzmitry@lahoda.pro>

* fixed tests

Signed-off-by: dzmitry-lahoda <dzmitry@lahoda.pro>

* fixed clippy

Signed-off-by: dzmitry-lahoda <dzmitry@lahoda.pro>

* fixed review comments

Signed-off-by: dzmitry-lahoda <dzmitry@lahoda.pro>

* adding tests and fixing bugs

Signed-off-by: dzmitry-lahoda <dzmitry@lahoda.pro>

* refactoring

Signed-off-by: dzmitry-lahoda <dzmitry@lahoda.pro>

* fix fmt

Signed-off-by: dzmitry-lahoda <dzmitry@lahoda.pro>

* fixed udeps

Signed-off-by: dzmitry-lahoda <dzmitry@lahoda.pro>

* fixed clippy

Signed-off-by: dzmitry-lahoda <dzmitry@lahoda.pro>

Squash

audit use of ValueQuery

audit usage of ValueQuery

audit ValueQuery in vault

audit usage of unwrap and ValueQuery in transaction-fee

Audit clippy warnings in curve-amm pallet

indexing and slicing warning have been suppressed for now; A larger refactor will be required to remove the indexing that remains.

Audit use of ValueQuery in dutch-auction

Fix compilation error in test_interest_rate_model_default

Audit/ fix clippy warnings in assets-registry and dutch-auction

Fix or temporarilly suppress various clippy warnings

rustfmt

Signed-off-by: Ben Luelo <benluelo@hotmail.com>

Audit clippy warnings in curve-amm pallet

indexing and slicing warning have been suppressed for now; A larger refactor will be required to remove the indexing that remains.

Fix compilation error in test_interest_rate_model_default

Audit/ fix clippy warnings in assets-registry and dutch-auction

Fix or temporarilly suppress various clippy warnings

rustfmt

Signed-off-by: Ben Luelo <benluelo@hotmail.com>

rustfmt

Signed-off-by: Ben Luelo <benluelo@hotmail.com>
  • Loading branch information
hussein-aitlahcen authored and benluelo committed Jan 3, 2022
1 parent 62f6e5b commit a76d63a
Show file tree
Hide file tree
Showing 146 changed files with 14,662 additions and 2,006 deletions.
55 changes: 25 additions & 30 deletions .github/workflows/check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ on:
- dali-chachacha
- picasso
workflow_dispatch:
concurrency: ci-check
jobs:
check:
runs-on:
Expand All @@ -20,23 +19,23 @@ jobs:
- sre
steps:
- uses: actions/checkout@v2
- uses: actions-rs/toolchain@v1
with:
profile: minimal
toolchain: stable
override: true
- uses: actions-rs/cargo@v1
- name: Cargo Check
- name: Setup toolchain
run: |
curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y
echo "$HOME/.cargo/bin:$PATH" >> $GITHUB_PATH
- name: Check
run: |
rustup target add wasm32-unknown-unknown
SKIP_WASM_BUILD=1 cargo check --all --benches
- name: Cargo Check Benchmark
- name: Benchmark
run: |
SKIP_WASM_BUILD=1 cargo check --features=runtime-benchmarks --workspace --release --exclude integration-tests
- name: Picasso Runtime Build
- name: Benchmark Develop
run: |
SKIP_WASM_BUILD=1 cargo check --features=runtime-benchmarks,develop --workspace --release --exclude integration-tests
- name: Picasso
run: |
cargo build --release -p picasso-runtime
- name: Picasso Runtime Build with develop feature
- name: Picasso Develop
run: |
cargo build --release -p picasso-runtime --features develop
linters:
Expand All @@ -48,20 +47,17 @@ jobs:
- sre
steps:
- uses: actions/checkout@v2
- uses: actions-rs/toolchain@v1
with:
profile: minimal
toolchain: stable
components: clippy
override: true
- name: Install Rust components and targets
- name: Setup toolchain
run: |
rustup target add wasm32-unknown-unknown
rustup component add rustfmt --toolchain nightly-x86_64-unknown-linux-gnu
rustup target add wasm32-unknown-unknown --toolchain nightly
curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y
echo "$HOME/.cargo/bin:$PATH" >> $GITHUB_PATH
- run: |
rustup show
rustup override unset
rustup show
- name: Cargo fmt
run: |
cargo +nightly fmt -- --check
cargo fmt -- --check
- name: Hadolint
env:
HADOLINT_VERSION: v2.8.0
Expand All @@ -78,7 +74,7 @@ jobs:
exit $total_exit_code
- name: Cargo clippy
run: |
cargo +nightly clippy -- -D warnings
cargo clippy -- -D warnings
- name: Cargo udeps
env:
UDEPS_VERSION: v0.1.24
Expand All @@ -91,7 +87,7 @@ jobs:
total_exit_code=0
while IFS= read -r crate; do
echo "=== $crate ==="
(cd "$crate"; SKIP_WASM_BUILD=1 cargo +nightly udeps -q --all-targets) || total_exit_code=$?
(cd "$crate"; SKIP_WASM_BUILD=1 cargo udeps -q --all-targets) || total_exit_code=$?
echo ""
done < <(find . -name "Cargo.toml" -not -path "./polkadot-launch/*" -not -path "./target/*" -exec dirname '{}' \;)
exit $total_exit_code
Expand All @@ -104,11 +100,10 @@ jobs:
- sre
steps:
- uses: actions/checkout@v2
- uses: actions-rs/toolchain@v1
with:
profile: minimal
toolchain: stable
override: true
- name: Setup toolchain
run: |
curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y
echo "$HOME/.cargo/bin:$PATH" >> $GITHUB_PATH
- name: Run Test
run: |
SKIP_WASM_BUILD=1 cargo test
Expand Down

0 comments on commit a76d63a

Please sign in to comment.