Fix polkadot-launch #1251

andor0 · 2022-07-04T21:54:31Z

Issue

https://app.clickup.com/t/2m3dvaz

polkadot-launch waits Running JSON-RPC WS server: or Listening for new connections strings in logs.
It works with tracing-core = "=0.1.26", but it doesn't work with a new versions (I checked 0.1.27 and 0.1.28 versions).

Description

frame/ibc* depend on ibc, ibc depends on tracing = { version = "0.1.35" }, tracing depends on tracing-core = { version = 0.1.27 }.
So I reverted tracing version in ibc.

vercel · 2022-07-04T21:54:34Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Ignored Deployments

Name	Status	Updated
pablo-staging	⬜️ Ignored (Inspect)	Jul 5, 2022 at 3:57PM (UTC)
pablo-storybook	⬜️ Ignored (Inspect)	Jul 5, 2022 at 3:57PM (UTC)
picasso-staging	⬜️ Ignored (Inspect)	Jul 5, 2022 at 3:57PM (UTC)
picasso-storybook	⬜️ Ignored (Inspect)	Jul 5, 2022 at 3:57PM (UTC)

frame/ibc-ping/Cargo.toml

frame/ibc/Cargo.toml

codecov-commenter · 2022-07-04T22:44:04Z

Codecov Report

Merging #1251 (bc8edb1) into main (be2aebf) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1251      +/-   ##
==========================================
- Coverage   38.06%   38.05%   -0.01%     
==========================================
  Files         345      345              
  Lines       64547    64547              
==========================================
- Hits        24568    24564       -4     
- Misses      39979    39983       +4

Impacted Files	Coverage Δ
frame/pablo/src/uniswap.rs	`98.57% <0.00%> (-0.72%)`	⬇️
frame/lending/src/helpers.rs	`95.03% <0.00%> (-0.68%)`	⬇️
frame/airdrop/src/lib.rs	`54.75% <0.00%> (-0.17%)`	⬇️
frame/composable-traits/src/lending/tests.rs	`99.41% <0.00%> (+0.58%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be2aebf...bc8edb1. Read the comment docs.

andresmechali

LGTM and solves the issue 🚀

dzmitry-lahoda

bors r+

also, seems like IBC updated its core but not maintained tracing in other crates. i mean if you are ok with old core or update others.

bors · 2022-07-05T09:24:57Z

👎 Rejected because of missing code owner approval

andor0 · 2022-07-05T11:07:02Z

bors r+

bors · 2022-07-05T11:07:08Z

👎 Rejected because of missing code owner approval

andor0 · 2022-07-05T13:01:13Z

bors r+

## Issue https://app.clickup.com/t/2m3dvaz polkadot-launch waits `Running JSON-RPC WS server:` or `Listening for new connections` [strings in logs](https://github.com/paritytech/polkadot-launch/blob/master/src/spawn.ts#L301-L303). It works with `tracing-core = "=0.1.26"`, but it doesn't work with a new versions (I checked `0.1.27` and `0.1.28` versions). ## Description `frame/ibc*` depend on [ibc](https://github.com/ComposableFi/ibc-rs), [ibc](https://github.com/ComposableFi/ibc-rs) depends on `tracing = { version = "0.1.35" }`, `tracing` depends on `tracing-core = { version = 0.1.27 }`. So I reverted `tracing` version in [ibc](https://github.com/ComposableFi/ibc-rs).

bors · 2022-07-05T13:43:32Z

This PR was included in a batch that successfully built, but then failed to merge into main. It will not be retried.

Additional information:

{"message":"Waiting on code owner review from ComposableFi/core, ComposableFi/parachain, ComposableFi/parachain-leads, and/or ComposableFi/sre.","documentation_url":"https://docs.github.com/articles/about-protected-branches"}

bors · 2022-07-05T15:57:05Z

Canceled.

andor0 · 2022-07-05T15:57:36Z

bors r+

bors · 2022-07-05T15:57:43Z

👎 Rejected by too few up-to-date approved reviews (some of the PR reviews are stale)

andor0 · 2022-07-05T16:19:06Z

bors r+

## Issue https://app.clickup.com/t/2m3dvaz polkadot-launch waits `Running JSON-RPC WS server:` or `Listening for new connections` [strings in logs](https://github.com/paritytech/polkadot-launch/blob/master/src/spawn.ts#L301-L303). It works with `tracing-core = "=0.1.26"`, but it doesn't work with a new versions (I checked `0.1.27` and `0.1.28` versions). ## Description `frame/ibc*` depend on [ibc](https://github.com/ComposableFi/ibc-rs), [ibc](https://github.com/ComposableFi/ibc-rs) depends on `tracing = { version = "0.1.35" }`, `tracing` depends on `tracing-core = { version = 0.1.27 }`. So I reverted `tracing` version in [ibc](https://github.com/ComposableFi/ibc-rs).

bors · 2022-07-05T17:08:16Z

Build failed (retrying...):

Unit Tests (With Coverage)

## Issue https://app.clickup.com/t/2m3dvaz polkadot-launch waits `Running JSON-RPC WS server:` or `Listening for new connections` [strings in logs](https://github.com/paritytech/polkadot-launch/blob/master/src/spawn.ts#L301-L303). It works with `tracing-core = "=0.1.26"`, but it doesn't work with a new versions (I checked `0.1.27` and `0.1.28` versions). ## Description `frame/ibc*` depend on [ibc](https://github.com/ComposableFi/ibc-rs), [ibc](https://github.com/ComposableFi/ibc-rs) depends on `tracing = { version = "0.1.35" }`, `tracing` depends on `tracing-core = { version = 0.1.27 }`. So I reverted `tracing` version in [ibc](https://github.com/ComposableFi/ibc-rs).

andor0 · 2022-07-05T17:17:44Z

bors r+

bors · 2022-07-05T17:17:45Z

Already running a review

bors · 2022-07-05T18:01:56Z

This PR was included in a batch that successfully built, but then failed to merge into main. It will not be retried.

Additional information:

{"message":"Waiting on code owner review from ComposableFi/core, ComposableFi/parachain, ComposableFi/parachain-leads, and/or ComposableFi/sre.","documentation_url":"https://docs.github.com/articles/about-protected-branches"}

andor0 · 2022-07-05T19:49:22Z

bors r+

## Issue https://app.clickup.com/t/2m3dvaz polkadot-launch waits `Running JSON-RPC WS server:` or `Listening for new connections` [strings in logs](https://github.com/paritytech/polkadot-launch/blob/master/src/spawn.ts#L301-L303). It works with `tracing-core = "=0.1.26"`, but it doesn't work with a new versions (I checked `0.1.27` and `0.1.28` versions). ## Description `frame/ibc*` depend on [ibc](https://github.com/ComposableFi/ibc-rs), [ibc](https://github.com/ComposableFi/ibc-rs) depends on `tracing = { version = "0.1.35" }`, `tracing` depends on `tracing-core = { version = 0.1.27 }`. So I reverted `tracing` version in [ibc](https://github.com/ComposableFi/ibc-rs).

bors · 2022-07-05T20:31:30Z

This PR was included in a batch that successfully built, but then failed to merge into main. It will not be retried.

Additional information:

{"message":"Waiting on code owner review from ComposableFi/core, ComposableFi/parachain, ComposableFi/parachain-leads, and/or ComposableFi/sre.","documentation_url":"https://docs.github.com/articles/about-protected-branches"}

andor0 · 2022-07-05T21:51:39Z

bors r+

## Issue https://app.clickup.com/t/2m3dvaz polkadot-launch waits `Running JSON-RPC WS server:` or `Listening for new connections` [strings in logs](https://github.com/paritytech/polkadot-launch/blob/master/src/spawn.ts#L301-L303). It works with `tracing-core = "=0.1.26"`, but it doesn't work with a new versions (I checked `0.1.27` and `0.1.28` versions). ## Description `frame/ibc*` depend on [ibc](https://github.com/ComposableFi/ibc-rs), [ibc](https://github.com/ComposableFi/ibc-rs) depends on `tracing = { version = "0.1.35" }`, `tracing` depends on `tracing-core = { version = 0.1.27 }`. So I reverted `tracing` version in [ibc](https://github.com/ComposableFi/ibc-rs).

bors · 2022-07-05T22:33:50Z

This PR was included in a batch that successfully built, but then failed to merge into main. It will not be retried.

Additional information:

{"message":"Waiting on code owner review from ComposableFi/core, ComposableFi/parachain, ComposableFi/parachain-leads, and/or ComposableFi/sre.","documentation_url":"https://docs.github.com/articles/about-protected-branches"}

alexkdefi

👍

KaiserKarel · 2022-07-06T07:49:57Z

bors r+

## Issue https://app.clickup.com/t/2m3dvaz polkadot-launch waits `Running JSON-RPC WS server:` or `Listening for new connections` [strings in logs](https://github.com/paritytech/polkadot-launch/blob/master/src/spawn.ts#L301-L303). It works with `tracing-core = "=0.1.26"`, but it doesn't work with a new versions (I checked `0.1.27` and `0.1.28` versions). ## Description `frame/ibc*` depend on [ibc](https://github.com/ComposableFi/ibc-rs), [ibc](https://github.com/ComposableFi/ibc-rs) depends on `tracing = { version = "0.1.35" }`, `tracing` depends on `tracing-core = { version = 0.1.27 }`. So I reverted `tracing` version in [ibc](https://github.com/ComposableFi/ibc-rs).

bors · 2022-07-06T08:49:37Z

This PR was included in a batch that successfully built, but then failed to merge into main. It will not be retried.

Additional information:

{"message":"Waiting on code owner review from ComposableFi/core, ComposableFi/parachain, ComposableFi/parachain-leads, and/or ComposableFi/sre.","documentation_url":"https://docs.github.com/articles/about-protected-branches"}

andor0 · 2022-07-06T14:02:50Z

This PR is a duplicate of #1270.

andor0 added 4 commits July 5, 2022 01:48

Revert tracing version

4456189

Bump polkadot-launch version

5a4eed4

Update polkadot-launch configuration

431d34c

Formatting

d60a105

Cleanup

8a678ab

benluelo previously approved these changes Jul 4, 2022

View reviewed changes

frame/ibc-ping/Cargo.toml Outdated Show resolved Hide resolved

frame/ibc/Cargo.toml Outdated Show resolved Hide resolved

andor0 dismissed benluelo’s stale review via 8a678ab July 4, 2022 21:57

andor0 changed the title ~~Feat/fix polkadot launch/andor0~~ Fix polkadot-launch Jul 4, 2022

andor0 added 2 commits July 5, 2022 02:46

Cleanup

5899ef7

Update docker/composable-sandbox.dockerfile

1df530c

benluelo approved these changes Jul 4, 2022

View reviewed changes

andor0 marked this pull request as ready for review July 5, 2022 08:32

andor0 requested a review from a team as a code owner July 5, 2022 08:32

andor0 requested a review from a team July 5, 2022 08:32

andor0 requested a review from a team as a code owner July 5, 2022 08:32

andor0 requested a review from a team July 5, 2022 08:32

andresmechali approved these changes Jul 5, 2022

View reviewed changes

dzmitry-lahoda approved these changes Jul 5, 2022

View reviewed changes

andor0 requested review from hussein-aitlahcen and KaiserKarel July 5, 2022 09:41

KaiserKarel approved these changes Jul 5, 2022

View reviewed changes

haroldsphinx approved these changes Jul 5, 2022

View reviewed changes

benluelo approved these changes Jul 5, 2022

View reviewed changes

haroldsphinx approved these changes Jul 5, 2022

View reviewed changes

hussein-aitlahcen approved these changes Jul 5, 2022

View reviewed changes

KaiserKarel requested review from a team July 6, 2022 07:44

KaiserKarel approved these changes Jul 6, 2022

View reviewed changes

alexkdefi approved these changes Jul 6, 2022

View reviewed changes

KaiserKarel mentioned this pull request Jul 6, 2022

Waiting on code owner review, yet code owners already approved. bors-ng/bors-ng#1521

Open

andor0 closed this Jul 6, 2022

KaiserKarel deleted the feat/fix-polkadot-launch/andor0 branch January 31, 2023 17:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix polkadot-launch #1251

Fix polkadot-launch #1251

andor0 commented Jul 4, 2022 •

edited

vercel bot commented Jul 4, 2022 •

edited

codecov-commenter commented Jul 4, 2022 •

edited

andresmechali left a comment

dzmitry-lahoda left a comment

bors bot commented Jul 5, 2022

andor0 commented Jul 5, 2022

bors bot commented Jul 5, 2022

andor0 commented Jul 5, 2022

bors bot commented Jul 5, 2022

bors bot commented Jul 5, 2022

andor0 commented Jul 5, 2022

bors bot commented Jul 5, 2022

andor0 commented Jul 5, 2022

bors bot commented Jul 5, 2022

andor0 commented Jul 5, 2022

bors bot commented Jul 5, 2022

bors bot commented Jul 5, 2022

andor0 commented Jul 5, 2022

bors bot commented Jul 5, 2022

andor0 commented Jul 5, 2022

bors bot commented Jul 5, 2022

alexkdefi left a comment

KaiserKarel commented Jul 6, 2022

bors bot commented Jul 6, 2022

andor0 commented Jul 6, 2022

Fix polkadot-launch #1251

Fix polkadot-launch #1251

Conversation

andor0 commented Jul 4, 2022 • edited

Issue

Description

vercel bot commented Jul 4, 2022 • edited

codecov-commenter commented Jul 4, 2022 • edited

Codecov Report

andresmechali left a comment

Choose a reason for hiding this comment

dzmitry-lahoda left a comment

Choose a reason for hiding this comment

bors bot commented Jul 5, 2022

andor0 commented Jul 5, 2022

bors bot commented Jul 5, 2022

andor0 commented Jul 5, 2022

bors bot commented Jul 5, 2022

bors bot commented Jul 5, 2022

andor0 commented Jul 5, 2022

bors bot commented Jul 5, 2022

andor0 commented Jul 5, 2022

bors bot commented Jul 5, 2022

andor0 commented Jul 5, 2022

bors bot commented Jul 5, 2022

bors bot commented Jul 5, 2022

andor0 commented Jul 5, 2022

bors bot commented Jul 5, 2022

andor0 commented Jul 5, 2022

bors bot commented Jul 5, 2022

alexkdefi left a comment

Choose a reason for hiding this comment

KaiserKarel commented Jul 6, 2022

bors bot commented Jul 6, 2022

andor0 commented Jul 6, 2022

andor0 commented Jul 4, 2022 •

edited

vercel bot commented Jul 4, 2022 •

edited

codecov-commenter commented Jul 4, 2022 •

edited