Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No Ticket] Protect Picasso runtime from out of consensus modification #2577

Merged
merged 2 commits into from
Dec 13, 2022

Conversation

vimukthi-git
Copy link
Contributor

This is to protect Picasso runtime from being modified without consensus. Need a process to verify runtime changes so that we don't run into blockers at the time of release.

@vimukthi-git vimukthi-git requested a review from a team December 6, 2022 17:15
@github-actions
Copy link

github-actions bot commented Dec 6, 2022

Nix commands for this PR

NOTE: You can also run our Nix commands in Docker. See the bottom of this comment.

Make sure you have setup the Composable community cache:

(you only need to run it once on your machine)

nix-shell -p cachix --command "cachix use composable-community"

Show all possible apps, shells and packages:

nix flake show "github:ComposableFi/composable/98676bf68479f6eb6492ac8eea296fffd0db5e0a --allow-import-from-derivation

Run the Composable node alone:

nix run "github:ComposableFi/composable/98676bf68479f6eb6492ac8eea296fffd0db5e0a#composable-node" -L

Spin up a local devnet:

nix run "github:ComposableFi/composable/98676bf68479f6eb6492ac8eea296fffd0db5e0a#devnet" -L --option sandbox relaxed --show-trace

Spin up a local XCVM devnet:

nix run "github:ComposableFi/composable/98676bf68479f6eb6492ac8eea296fffd0db5e0a#devnet-xcvm" -L

View the docs:

nix run ".#docs-server"

Run this without Nix in Docker.

docker run --rm -v /var/run/docker.sock:/var/run/docker.sock -v nix:/nix -it nixos/nix bash -c "nix-env -iA nixpkgs.cachix && cachix use composable-community && nix run github:ComposableFi/Composable/98676bf68479f6eb6492ac8eea296fffd0db5e0a#devnet-dali -L --extra-experimental-features nix-command --extra-experimental-features flakes"

NOTE: You can swap devnet-dali in the command above with any Nix package
For more info on how to use Nix, check out our Nix docs
Note that the initial build may take about one hour if it has not been cached by our CI yet. Once it is cached, builds should take about one minute. We currently do not provide build caches for ARM machines such as M1 Macs, but building on ARM is supported.

@vercel
Copy link

vercel bot commented Dec 6, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Updated
pablo-nightly ⬜️ Ignored (Inspect) Dec 12, 2022 at 8:21PM (UTC)
picasso-nightly ⬜️ Ignored (Inspect) Dec 12, 2022 at 8:21PM (UTC)

@bostercf
Copy link
Contributor

bostercf commented Dec 6, 2022

Should this be done for Dali / Composable as well?

@vimukthi-git
Copy link
Contributor Author

@bostercf For dali no as it's supposed to be the testing ground for bleeding edge stuff. For now the only production environment with user data is Picasso, so for Composable we can add later I believe.

Copy link
Contributor

@andyjsbell andyjsbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vimukthi-git

@vimukthi-git
Copy link
Contributor Author

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Dec 9, 2022

refresh

✅ Pull request refreshed

@vercel vercel bot temporarily deployed to Preview – pablo-nightly December 9, 2022 14:02 Inactive
@vercel vercel bot temporarily deployed to Preview – picasso-nightly December 9, 2022 14:43 Inactive
@vimukthi-git vimukthi-git merged commit c71257c into main Dec 13, 2022
@vimukthi-git vimukthi-git deleted the stricter_picasso_review branch December 13, 2022 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants